fix(instrumentation-kafkajs): fix instr to work with [email protected] and earlier #2787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d earlier The tests broke on [email protected] and earlier. The instrumentation crashed on [email protected] and earlier. Refs: open-telemetry#2784 (comment) Fixes: open-telemetry#2784
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2787 +/- ##
==========================================
- Coverage 89.50% 89.45% -0.05%
==========================================
Files 174 174
Lines 8318 8319 +1
Branches 1591 1592 +1
==========================================
- Hits 7445 7442 -3
- Misses 873 877 +4
🚀 New features to boost your workflow:
|
Contributor
Author
|
Aside: The "Add component labels" workflow (run: https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/14390963192/job/40357662690?pr=2787) did not add the Ah, it wasn't added when instr-kafkajs was added (which was after the component-label-map.yml file was initially created). |
…tically add the pkg:instrumentation-kafkajs label (required for TAV testing PRs)
Contributor
Author
Added in commit 4b06cc8 |
maryliag
approved these changes
Apr 11, 2025
JamieDanielson
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests broke on [email protected] and earlier.
The instrumentation crashed on [email protected] and earlier.
Refs: #2784 (comment)
Fixes: #2784